[Repositories] Haiku name should not be used explicitly

[KapiX]

Given that Haiku can be built in non-official mode, Haiku name should not be used directly.

Here: ​http://cgit.haiku-os.org/haiku/tree/src/preferences/repositories/RepositoriesView.cpp#n154

Should be done like in Tracker: ​http://cgit.haiku-os.org/haiku/tree/src/kits/tracker/FSUtils.cpp#n735

[humdinger]

Even simpler: "Enable the repositories to be used by package management:"

[axeld]

While I don't mind changing the string, I don't think anybody is actually using that non-official mode currently, so I don't think we should dump any developer resources in this direction -- if anyone actually needs this, he could send in the patches himself :-)

[humdinger]

Yeah, agreed. But here it's easiest to just leave out "Haiku" completely. It's unneeded, we don't say "Open with Haiku's Tracker" etc. either. :)

[anirudh]

Here's the patch, replaced the string and removed the word 'Haiku', must be fine now! :) And there goes my first contribution.

[humdinger]

There's still the "Select" in line 153 that has to be removed. Also "package" instead of "Packet" and remove the space in front of "Enable".

[anirudh]

Replying to humdinger:

There's still the "Select" in line 153 that has to be removed. Also "package" instead of "Packet" and remove the space in front of "Enable".

I hope things are correct now with the new patch. Sorry for messing up.

[humdinger]

For one, it's still lower case "package". Then the second patch relies on the 1st patch. You should create a new single patch to be applied to the orignal file. So revert by checking out the original RepositoriesView.cpp and make your changes once more. Dunno if there's a better solution, I'm not that familiar with the git intricacies...

[scottmc]

Please break the long line up into two lines like the orignal code was. Please review the coding guidelines.

"A line must not have more than 80 columns; when wrapping a line, you usually indent one extra tab, but that can get more depending on the contents."

​https://www.haiku-os.org/development/coding-guidelines/

[scottmc]

Still off by two spaces. "...you usually indent one extra tab, but that can get more depending on the contents."

Tab stops should be set to 4 spaces.

[humdinger]

Read: replace the 2 spaces at the start of line 154 with one tab.

[anirudh]

Replying to humdinger:

Read: replace the 2 spaces at the start of line 154 with one tab.

And finally done. Really sorry for the mess, won't happen in future. Understood the working. Let me know if there's any more changes.

[humdinger]

Really sorry, I don't want to frustrate you... It's one tab, not 4 spaces.

[anirudh]

Updated String

[anirudh]

Replying to humdinger:

Really sorry, I don't want to frustrate you... It's one tab, not 4 spaces.

Upon one backspace, the whole tab gets moved. It's one tab, I'm not sure why it shows 4 spaces for you. Please check now.

[waddlesplash]

Really sorry, I don't want to frustrate you... It's one tab, not 4 spaces.

@scottmc, @humdinger: Trac displays tabs in patches as spaces. The actual patch file looks OK to me.

[humdinger]

@waddlesplash: the original patch had those 4 spaces, anirudh has corrected since.
Applied with hrev51006. Thanks!

[anirudh]

Marking this ticket with the keyword gsoc2017 to indicate it as one of my submission for Summer of Code 2017.