Opened 6 years ago
Closed 2 years ago
#13845 closed enhancement (fixed)
Expose the MediaPlayer playlist as a scripting object
| Reported by: | owenca | Owned by: | stippi |
|---|---|---|---|
| Priority: | normal | Milestone: | R1/beta4 |
| Component: | Applications/MediaPlayer | Version: | R1/Development |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
It should be able to return the number of tracks and the title of a specified track.
Attachments (7)
Change History (19)
comment:1 by , 6 years ago
| patch: | 0 → 1 |
|---|
by , 6 years ago
| Attachment: | 0003-Add-PlaylistTrackCount-and-PlaylistTrackTitle-to-scr.patch added |
|---|
comment:2 by , 6 years ago
by , 6 years ago
| Attachment: | 0004-Expose-the-current-track-as-a-scripting-object.patch added |
|---|
by , 6 years ago
| Attachment: | CurrentTrack.png added |
|---|
comment:4 by , 6 years ago
Please see the attached patch for exposing the current track and the screenshot for the hey command.
by , 6 years ago
| Attachment: | Properties of CurrentTrack.png added |
|---|
by , 6 years ago
| Attachment: | infinite loop.png added |
|---|
comment:5 by , 6 years ago
I got it to work except that there is a bug when quitting MediaPlayer. It would get into an infinite loop after a hey command. Without any hey commands, it would print the supplier error message once and exit without getting into the infinite loop. Please see the attached screenshots.
by , 6 years ago
| Attachment: | 0005-Expose-the-current-track-as-a-scripting-object.patch added |
|---|
by , 6 years ago
| Attachment: | 0005-Expose-the-current-track-as-a-scripting-object.2.patch added |
|---|
comment:7 by , 6 years ago
I have pushed patches 3 and 4 for review on Gerrit (as https://review.haiku-os.org/18 and https://review.haiku-os.org/20 respectively). However patch 5 does not apply above them nor without them. Can you rebase it?
You should be able to update changes 3 and 4 on Gerrit if needed (read about "change IDs" in Gerrit) and push patch 5 directly there (git push origin ...:refs/for/master, where ... is the hash of the commit you want to push for review), too.
Your help testing Gerrit is kindly appreciated.
comment:8 by , 6 years ago
I have just reviewed the patches: Patch 4 and the first Patch 5 are obsolete. Can you mark them obsolete? The option seems unavailable to me now.
The 2nd Patch 5 is supposed to be applied on top of Patch 3. I will try to update this on Gerrit.
comment:9 by , 6 years ago
| patch: | 1 → 0 |
|---|
comment:12 by , 2 years ago
| Milestone: | Unscheduled → R1/beta4 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Note that #13829 also has some scripting functions