Opened 21 months ago

Last modified 14 months ago

#13845 new enhancement

Expose the MediaPlayer playlist as a scripting object

Reported by: owenca Owned by: stippi
Priority: normal Milestone: Unscheduled
Component: Applications/MediaPlayer Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

It should be able to return the number of tracks and the title of a specified track.

Change History (16)

comment:1 by owenca, 21 months ago

Has a Patch: set

comment:2 by waddlesplash, 21 months ago

Note that #13829 also has some scripting functions

comment:3 by owenca, 21 months ago

Should I merge that patch into mine?

by owenca, 21 months ago

Attachment: CurrentTrack.png added

comment:4 by owenca, 21 months ago

Please see the attached patch for exposing the current track and the screenshot for the hey command.

by owenca, 21 months ago

by owenca, 21 months ago

Attachment: infinite loop.png added

comment:5 by owenca, 21 months ago

I got it to work except that there is a bug when quitting MediaPlayer. It would get into an infinite loop after a hey command. Without any hey commands, it would print the supplier error message once and exit without getting into the infinite loop. Please see the attached screenshots.

comment:6 by owenca, 21 months ago

I fixed it. Please see the new patch.

comment:7 by pulkomandy, 20 months ago

I have pushed patches 3 and 4 for review on Gerrit (as https://review.haiku-os.org/18 and https://review.haiku-os.org/20 respectively). However patch 5 does not apply above them nor without them. Can you rebase it?

You should be able to update changes 3 and 4 on Gerrit if needed (read about "change IDs" in Gerrit) and push patch 5 directly there (git push origin ...:refs/for/master, where ... is the hash of the commit you want to push for review), too.

Your help testing Gerrit is kindly appreciated.

comment:8 by owenca, 20 months ago

I have just reviewed the patches: Patch 4 and the first Patch 5 are obsolete. Can you mark them obsolete? The option seems unavailable to me now.

The 2nd Patch 5 is supposed to be applied on top of Patch 3. I will try to update this on Gerrit.

comment:9 by pulkomandy, 14 months ago

Has a Patch: unset
Note: See TracTickets for help on using tickets.