[Installer] should ignore cache directory

[diver]

At least HaikuDepot stores a few thousands icons in cache directory. Cloning already installed haiku to another partition becomes really slow in this case.

​https://xref.plausible.coop/source/xref/haiku/src/apps/installer/WorkerThread.cpp#95

[waddlesplash]

Fixed in hrev53252.

[diver]

This fix actually caused problems. Since cache isn't copied anymore it is not present for case when you use Installer to copy existing installation to another partition.

Then all apps that need cache folder will fail. For example HaikuDepot will complain.

To workaround it one can do this:

unmount ~/config
mkdir ~/config/cache

[pulkomandy]

Why do we want to ignore it in the first place? It's not /tmp, the cache is surely meant to be somewhat persistant. If an app is storing too much data there, we should rather fix that?

Please always include a description in tickets, that would help :)

[pulkomandy]

Change reverted in hrev53578, we need something that doesn't break the resulting install.

[kallisti5]

Removing blocker status since it was reverted. This one is still an issue but doesn't appear to be a R1 Beta2 blocker

[CodeforEvolution]

I think I have a solution for this! I’m quite certain that the find_directory function has a parameter that allows one to have a folder created if it doesn’t already exist. This would mean that cache using applications could utilize this feature of find_directory and the cache folder can simply be ignored again by the Installer.

[pulkomandy]

We cannot be sure that all applications use this api. Infactwe know some don't, and this iswhy this was done and then reverted. I think we should rather fix haikudepot to not download thousands of icon files when you run it and let Installer do it's job normally.

[leavengood]

I started working on a fix to Installer which just creates the needed directories on the installed-to volume after files have been copied. I believe there were some other ones I wanted to create too. I could try to restore my work on that and finish it up. I forget what held it up, but I was working on it last summer.

But I agree about the huge icon cache. Why can't HaikuDepot render icons directly from the packages?

[pulkomandy]

Because it does this for packages which are not downloaded/installed.

But it could still store them more efficiwntly, for example as a single file with many icon attributes or resources. That would solve the issue without needing any special-casing in Installer

[pulkomandy]

Should be fixed in HaikuDepot side instead, see #15370.

[nielx]

Remove milestone for tickets with status = closed and resolution != fixed