Opened 5 years ago
Last modified 5 years ago
#16117 new bug
HaikuDepot: Haiku name is not under distro ifdef
| Reported by: | KapiX | Owned by: | apl-haiku |
|---|---|---|---|
| Priority: | normal | Milestone: | Unscheduled |
| Component: | Applications/HaikuDepot | Version: | R1/Development |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
https://git.haiku-os.org/haiku/tree/src/apps/haikudepot/server/ServerHelper.cpp#n179
See https://www.haiku-os.org/community/guidelines_creating_haiku_distribution/
Additionally there are a bunch of error window titles with Title Case, which stand out. Haiku uses sentence casing basically everywhere.
Change History (9)
comment:1 by , 5 years ago
comment:2 by , 5 years ago
Distributions are not allowed to use Haiku name by default, that includes messages generated by the system and bundled apps. There is a configure option to switch to non-official build, which removes them (most visible effect is missing Haiku logo at boot screen).
I don't remember whether it was decided to not use Haiku name in messages at all, because I can't find any references to it in source code: https://xref.landonf.org/source/search?q=HAIKU_OFFICIAL_RELEASE&defs=&refs=&path=&hist=&type=&project=haiku
@PulkoMandy, @waddlesplash: can you shed some light on this?
Anyway, having Haiku mentioned with no way to disable it makes it burdensome to create an unofficial build and distribute it.
BTW there is still a similar TODO in mount_server: https://github.com/haiku/haiku/blob/dc92c471b93f3b4615049a881da654df7555410b/src/servers/mount/AutoMounter.cpp#L984
Also in terminal: https://git.haiku-os.org/haiku/tree/src/apps/terminal/TermApp.cpp#n339
comment:5 by , 5 years ago
I don't think we have DISTRO_NAME define, and the only one in cpp files is in Deskbar: https://xref.landonf.org/source/xref/haiku/src/apps/deskbar/DeskbarMenu.cpp#250
So changing to just system makes most sense.
comment:6 by , 5 years ago
Hmm, it just hit me: should HaikuDepot's name depend on that ifdef as well? On unofficial builds it could change to Depot.
comment:7 by , 5 years ago
Dialogs fixed in hrev54262, but the app naming question is unresolved of course.
comment:8 by , 5 years ago
Hi @waddlesplash; probably not one for the very short-term, but would it make sense to rename the application to "Depot" or "PackageDepot" to side-step this problem?
Aside from the capitalization of the error titles, would you please elaborate on the specific problem that this ticket is covering as I am not able to understand from the description above.