[Media] prefs isn't font sensitive (easy)

[diver]

Media prefs isn't font sensetive. Tested with default font settings under vmware with rev16444. Screenshots will follow. Oh, btw, isnt' Media should say anything if it can't load media_server?

[diver]

audio settings

[diver]

video settings

[korli]

hopefully fixed in revision 16450.

[diver]

gui

[korli]

Fixed

[diver]

Ok, if you try to set 14th font size or larger you could see that several text labels wont fit in and will cut off.

[diver]

Big font problems

[diver]

Could this be fixed in hrev24765?

[stippi]

The patch from hrev24765 just touched the window itself, ie the container views. This bug might also refer to the Mixer node's view and other node supplied views which are embedded into the preflet. When I looked at it (I just get the Mixer view though), it looked very fine to me. Could be that the Mixer is already properly layouting itself. If someone has the time, please test the preflet with different font sizes and report your findings. :-)

[axeld]

The DefaultMediaTheme is supposed to do all the layout - currently it's not that pretty and not very powerful, though. Since we now have a layout engine, it should use that one instead.

[jalopeura]

Updating to use the system layout engine.

[stippi]

Replying to jalopeura:

Updating to use the system layout engine.

Just to make sure: Do you mean you are working on it? Or did you already work on it and forgot to attach the patch?

[jalopeura]

Replying to stippi:

Just to make sure: Do you mean you are working on it? Or did you already work on it and forgot to attach the patch?

I am working on it.

[jalopeura]

Attaching a patch, with the following notes and caveats:

• Checked font sizes 12 and 18.

• This also fixes ticket #1801; the text mentioned there is now visible.

• Everything but the audio mixer had already been updated to use the layout manager, so that's all this patch touches.

• BOptionPopUp and BSlider are not layout-friendly (at least, they don't accept a constructor without a BRect - although BChannelSlider did accept such a constructor), so instead they take a default BRect of (0,0,50,100).

• BSlider and BChannelSlider have not been tested - with my "hardware"(vmware emulating sb16), I get no slider controls at all. BOptionPopUp looks fine, even with the non-layout constructor.

• I changed the MakeViewFor() functions in DefaultMediaTheme so the BRect parameter defaults to NULL. They could probably be taken out entirely, as I believe they are all used internally only, except one which is most likely only called from MediaWindow. However, I wasn't sure, so I left them in to be safe.

[jalopeura]

Patch

[stippi]

I've finally managed to test this patch (sorry for the delay), but I am sorry to say that it doesn't work at all yet. The problem here is that you haven't had a chance to test parameter webs with channel sliders. Do you want to keep working on this? The HDA driver or the OpenSound package may work in one of the emulators, so you could check your patch with that. Is this an option?

[jalopeura]

I was concerned about being unable to test those sliders. I'll look into it and see if I can get some to show up for me.

[korli]

Maybe you can try on VirtualBox with the virtual ICH audio device.

[jalopeura]

Incomplete Patch

[jalopeura]

I updated the main window to use layout and ChannelSliders are working for me, but I'm still having the following two problems:

1) The container view on the main window doesn't resize with the window, even though the list view and the separator bar do. I can't figure out what I'm doing differently with that view to make it stay fixed in size.

2) When DefaultMediaTheme returns a single group (in a scroll view), it works fine - the scroll view is sized to the container view and the scroll bars allow you to see the entirety of the contained group view. But when it returns multiple groups (in scrolls views in a tab view), the scroll views are sized to the contained group views, and not to the containing tab view, so you can't see the whole view.

I have spent the last three days trying to track down these issues and have been unsuccessful, so if anyone has any ideas, please let me know. I'd even be willing to delve into the BTabView class if someone is reasonably certain that's where the problem lies.

[stippi]

I am going to have a look, sorry for the lag!

[diver]

Any news Stephan?

[stippi]

The patch introduced a number of issues and regressions, IIRC, that's why I didn't apply it.

[jalopeura]

The issues illustrated by the screenshots no longer occur (at least with the controls that show up for my setup). At font size 18, some of the text is shortened (gracefully, with '...'), but no text simply stops short, or gets covered up by other controls.

When I worked on this previously, I came to the conclusion that at least part of the problem was bugs in the layout code; perhaps these have been fixed since then? If anyone is still having this problem, I'd be willing to work on it again, if I can just reproduce it.

[stippi]

I think the issues have been fixed by Alex Wilson in the meantime. Alex, please reopen if this was not supposed to be closed.