Opened 16 years ago
Closed 16 years ago
#2508 closed enhancement (invalid)
[MediaPlayer] add icons to playlist (easy)
| Reported by: | diver | Owned by: | stippi |
|---|---|---|---|
| Priority: | normal | Milestone: | R1 |
| Component: | Applications/MediaPlayer | Version: | R1/pre-alpha1 |
| Keywords: | Cc: | codeanxiety@… | |
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
MediaPlayer already show icons in Recent menu.
It would be nice if it would the same for Playlist menu and Playlist window itself.
Attachments (1)
Change History (6)
comment:1 by , 16 years ago
| Summary: | [MediaPlayer] add icons to playlis → [MediaPlayer] add icons to playlist (easy) |
|---|
by , 16 years ago
| Attachment: | MediaPlayer - Playlist Icons.diff added |
|---|
follow-up: 3 comment:2 by , 16 years ago
| Cc: | added |
|---|
I added the file icons to the playlist and moved the green playback status arrow to the right side.
comment:3 by , 16 years ago
Replying to anxiety:
I added the file icons to the playlist and moved the green playback status arrow to the right side.
Thanks for the patch. Though I'm wondering why you don't use the icon from the node itself. http://www.beunited.org/bebook/The%20Storage%20Kit/NodeInfo.html#GetIcon()
comment:4 by , 16 years ago
| Owner: | changed from to |
|---|
comment:5 by , 16 years ago
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
I have looked at this patch, and also fixed BNodeInfo::GetTrackerIcon() in the process, but other developers here and myself agree that the additional icon only adds more clutter to the playlist window, it doesn't really add something useful. If it were small previews of movies perhaps, but the file icon is not so useful. We would rather add the playing time for example. So I will close this as "won't fix". But thanks for the work anyways, the patch was fine otherwise (although it should have used BNodeInfo::GetTrackerIcon()), I hope you understand!
Adds file icons to playlist