Opened 11 years ago

Closed 11 years ago

#2508 closed enhancement (invalid)

[MediaPlayer] add icons to playlist (easy)

Reported by: diver Owned by: stippi
Priority: normal Milestone: R1
Component: Applications/MediaPlayer Version: R1/pre-alpha1
Keywords: Cc: codeanxiety@…
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

MediaPlayer already show icons in Recent menu.
It would be nice if it would the same for Playlist menu and Playlist window itself.

Attachments (1)

MediaPlayer - Playlist Icons.diff (4.4 KB ) - added by anxiety 11 years ago.
Adds file icons to playlist

Download all attachments as: .zip

Change History (6)

comment:1 by diver, 11 years ago

Summary: [MediaPlayer] add icons to playlis[MediaPlayer] add icons to playlist (easy)

by anxiety, 11 years ago

Adds file icons to playlist

comment:2 by anxiety, 11 years ago

Cc: codeanxiety@… added

I added the file icons to the playlist and moved the green playback status arrow to the right side.

in reply to:  2 comment:3 by korli, 11 years ago

Replying to anxiety:

I added the file icons to the playlist and moved the green playback status arrow to the right side.

Thanks for the patch. Though I'm wondering why you don't use the icon from the node itself. http://www.beunited.org/bebook/The%20Storage%20Kit/NodeInfo.html#GetIcon()

comment:4 by korli, 11 years ago

Owner: changed from marcusoverhagen to stippi

comment:5 by stippi, 11 years ago

Resolution: invalid
Status: newclosed

I have looked at this patch, and also fixed BNodeInfo::GetTrackerIcon() in the process, but other developers here and myself agree that the additional icon only adds more clutter to the playlist window, it doesn't really add something useful. If it were small previews of movies perhaps, but the file icon is not so useful. We would rather add the playing time for example. So I will close this as "won't fix". But thanks for the work anyways, the patch was fine otherwise (although it should have used BNodeInfo::GetTrackerIcon()), I hope you understand!

Note: See TracTickets for help on using tickets.