Unarchived BTextControl's _BTextInput_ has a bad text rect

[shinta]

When we unarchived BTextControl, the position of text rect of its text view (_BTextInput_) is bad. Top margin is too large.

Haiku: hrev26161
​SHINTA (bug No.20)

[shinta]

This is the symptom.

[shinta]

In _BTextInput_::AlignTextRect(), LineHeight(0) returns 1 if BTextControl is unarchived. So, I used font_height instead of LineHeight(0).

Additionaly, BTextControl::_InitData() doesn't need to configure text rect because AlignTextRect() is called just after.

[shinta]

Above patch fixes this bug.

[stippi]

I don't understand the change to TextControl.cpp at all. As for the change to TextInput.cpp, I am not sure yet - it should be investigated why LineHeight(0) fails for the case when the control is unarchived. The patch looks like a workaround, not like the fix to the real problem.

[shinta]

Above patch is another idea.

LineHeight(0) calls _FindLineBreaks() eventually. I don't know whether removing check of fStyles->IsValidNullStyle() is OK or not. But, at leaset, it seems strange that ascent and descent aren't set when fStyles->IsValidNullStyle() is false.

[pulkomandy]

hrev52124 shows that the problem is not reproductible - archiving and unarchiving works fine. I assume it has been fixed since then, unless there is some application still reproducing this.