Opened 10 years ago

Closed 10 years ago

#2952 closed bug (fixed)

Right Control Mismapped in Some Keymaps

Reported by: bonefish Owned by: aldeck
Priority: high Milestone: R1/alpha1
Component: Preferences/Keymap Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

  • American and US-International keymaps: The right Control key acts like Option. It is unaffected by the "menu key" preference.
  • German keymap: The right Control key always acts like Command, even if Alt is set as "menu key".

Attachments (2)

keymap-right-control.png (19.5 KB) - added by bonefish 10 years ago.
keymaps-right-control.diff (16.2 KB) - added by aldeck 10 years ago.

Download all attachments as: .zip

Change History (13)

Changed 10 years ago by bonefish

Attachment: keymap-right-control.png added

comment:1 Changed 10 years ago by aldeck

I remember this "issue". See hrev27086 hrev27087, and the beginning ;) of the thread: http://www.freelists.org/archives/haiku-development/08-2008/msg00613.html

comment:2 Changed 10 years ago by aldeck

see also hrev27095 and #2139

comment:3 Changed 10 years ago by bonefish

I'm not familiar with the implementation, but at least I don't see a fundamental problem why it shouldn't be possible to map everything correctly for every keymap and for both Alt and Control as Command key. If that cannot be done with our current design, the design has to be changed.

ATM Haiku is horrible to use for me and probably most touch typists using Control as Command key.

comment:4 Changed 10 years ago by axeld

IIRC the french keymap was problematic, but if that is the case, just leave that one as is, and otherwise reapply your hrev27086 again, please.

comment:5 Changed 10 years ago by aldeck

I'll have a look again in the next days, but IIRC, people didn't like the right ctrl/alt to be switchable because alt-gr is used very frequently on some keymaps, and it was confusing in alt (or ctrl mode, i don't remember right now), or something like that... My goal at that time was to fix #2139 and it ended up not needing to touch the keymaps, but eventually i'd be for fixing them and find solutions to please everyone.

comment:6 in reply to:  5 Changed 10 years ago by bonefish

Replying to aldeck:

I'll have a look again in the next days, but IIRC, people didn't like the right ctrl/alt to be switchable because alt-gr is used very frequently on some keymaps, and it was confusing in alt (or ctrl mode, i don't remember right now), or something like that... My goal at that time was to fix #2139 and it ended up not needing to touch the keymaps, but eventually i'd be for fixing them and find solutions to please everyone.

That would be great. Regarding AltGr and Control, the keymap should just match the legends on the key. I.e. AltGr should work like AltGr regardless of the menu key setting. The right Control key should work as Command when Control is set as Command key, otherwise it should just act like Control (e.g. together with "C" it should send SIGINT in the Terminal). If people preferring Alt as Command key like to use the right Control key as Command key too, they should edit the keymap.

Which reminds me: Editing the keymap should be made easier with the Keymap preflet. I'm thinking of a small area showing the properties of the last-pressed key and allowing to edit them. Including the modifiers.

comment:7 Changed 10 years ago by aldeck

Owner: changed from axeld to aldeck
Status: newassigned

Please try this patch on the keymaps. Now they are all the same, key 0x60 -> RControl, key 0x5f -> ROption (AltGr). No key produces RCommand as that was the case for RControl before.

Since hrev27095, Menus shortcuts and Menu pref only watches/change LCommand and LControl. The right part is unchanged whatever the option. As you suggest, we might change that so that the right control follows the setting again (leaving ROption unchanged), it should be ok for everyone with the new keymaps.

Tell me how the keymaps work for you, i'll then patch the preflet too.

Changed 10 years ago by aldeck

Attachment: keymaps-right-control.diff added

comment:8 Changed 10 years ago by bonefish

With the patch the situation for American and US-International is as follows:

  • If Command = Alt: They work as expected, save for the right Alt, which acts like Option.
  • If Command = Ctrl: Left Control and Alt work OK, but right Alt is still Option and right Control behaves like the left Alt (respectively like the right Alt should).

German keymap:

  • If Command = Alt: Works as expected.
  • If Command = Control: Left Control and Alt work OK. Right Alt (AltGr) works OK. Right Control behaves like the left Alt.

comment:9 Changed 10 years ago by stippi

Does this really need to be in the R1/alpha milestone?

comment:10 in reply to:  9 Changed 10 years ago by bonefish

Replying to stippi:

Does this really need to be in the R1/alpha milestone?

At least I find Haiku quite annoying to use due to that.

comment:11 Changed 10 years ago by axeld

Resolution: fixed
Status: assignedclosed

This has been fixed in the mean time.

Note: See TracTickets for help on using tickets.