getpeername() succeeds on unconnected sockets

[bonefish]

hrev28311

A getpeername() after a connect() on a TCP socket succeeds even if

• the socket is non-blocking and the connection has not been established, or
• the socket is blocking and connect() timed out.

In either case getpeername() should fail with ENOTCONN.

The problem seems to be that getpeername() is fully implemented in the socket module and doesn't inquire the connection state. Or that the TCP module should set the peer address only when the connection is established and unset it when disconnected.

[phoudoin]

An easy fix is in src/add-ons/kernel/network/stack/net_socket.cpp

status_t
socket_getpeername(net_socket* _socket)
{
    net_socket_private* socket = (net_socket_private*)_socket;
    if (!socket->is_connected)
        return ENOTCONN;

    ...
}

Not great though, in the public socket API part of this module, net_socket_private is supposed to be unknown.

[phoudoin]

Stupid fix, in fact, as it will break for connectionless sockets, like UDP. It means that, indeed, TCP module should not set peer address public until connected.

[pulkomandy]

Is this not fixed by hrev54132? In that case, what else needs to be done?

[korli]

combined with hrev54113 and hrev54118 this is fixed.