Opened 10 years ago

Closed 10 years ago

#3393 closed bug (fixed)

Tracker: Cannot move icons on desktop anymore

Reported by: rossi Owned by: anevilyak
Priority: normal Milestone: R1
Component: Applications/Tracker Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Icons (displayed on the desktop - both symlinks and actual files) cannot be moved around anymore. If you click an icon and try to move it with the mouse, the icon snaps back into its original position upon release of the mouse button.

This happens on hrev29093.

Change History (13)

comment:1 Changed 10 years ago by anevilyak

Owner: changed from axeld to anevilyak

Most likely my fault, will look tonight.

comment:2 Changed 10 years ago by anevilyak

Can you try rolling back to hrev29091 and see if it works then? I suspect I know where the problem lies.

comment:3 Changed 10 years ago by rossi

Currently rolling back to hrev29091, the build will take some time, will give you feedback in app. 2-3h.

comment:4 Changed 10 years ago by rossi

As per your expectation, hrev29091 works perfectly fine.

comment:5 Changed 10 years ago by stippi

Are you building Haiku on your iPhone or on BeOS? /me pets Q6600 and brags about under four minutes build times... :-P

comment:6 Changed 10 years ago by anevilyak

There was a code block in MoveSelectionTo which checked if the source and destination window was the same (and not creating a link) to handle the move icon logic that I accidentally destroyed while refactoring...will hopefully be able to reinstate that in a few hours unless Stephan wants to beat me to it :) Still at work here.

comment:7 in reply to:  5 Changed 10 years ago by rossi

Replying to stippi:

Are you building Haiku on your iPhone or on BeOS? /me pets Q6600 and brags about under four minutes build times... :-P

Nope, on a Lifebook Q (Core Solo U1400) - but what this machine is lacking in raw performance its delivering in style and true mobility ;-) actually its dimensions (at 18mm and 1kg with full I/O including ExpressCard and built-in 3G it even beats the much hyped Mac Air) are the key asset and it looks just fabulous ;-) now - you brag about power, I about style ;-)

comment:8 Changed 10 years ago by anevilyak

Resolution: fixed
Status: newclosed

Fixed in hrev29095, sorry about that.

comment:9 Changed 10 years ago by bga

Resolution: fixed
Status: closedreopened

There are still some anomalies that seem to be related to this. I just noticed the following glitches:

1 - If you select 2 icosn, side by side, and move them to a different spot, thet will be moved one over the other (normally they would keep their relative positions).

2 - When you move an icon to a different spot, it is not being dropped in the point that you release the mouse button but in a nearby spot (maybe it is snapping to grid?), which is also a different behaviour than what used to happen.

comment:10 Changed 10 years ago by anevilyak

Please try again with hrev29096.

comment:11 Changed 10 years ago by bga

It seems you forgot to commit changes to PoseView.h. The build is broken:

C++ generated/objects/haiku/x86/release/kits/tracker/PoseView.o 
/Data/development/haiku/haiku/src/kits/tracker/PoseView.cpp:4364: prototype for `void BPrivate::BPoseView::MoveSelectionInto(BPrivate::Model *, BPrivate::BContainerWindow *, BPrivate::BContainerWindow *, long unsigned int, BPoint, bool, bool, bool, bool, BPoint, bool)' does not match any in class `BPrivate::BPoseView'
/Data/development/haiku/haiku/src/kits/tracker/PoseView.h:335: candidates are: static void BPrivate::BPoseView::MoveSelectionInto(BPrivate::Model *, BPrivate::BContainerWindow *, BPrivate::BContainerWindow *, long unsigned int, BPoint, bool, bool = false, bool = false, bool = false)
/Data/development/haiku/haiku/src/kits/tracker/PoseView.cpp:4351:                 void BPrivate::BPoseView::MoveSelectionInto(BPrivate::Model *, BPrivate::BContainerWindow *, bool, bool = false, bool = false, bool = false)

comment:12 Changed 10 years ago by anevilyak

Yeah, I did. Make that: try hrev29099 :)

comment:13 Changed 10 years ago by bga

Resolution: fixed
Status: reopenedclosed

Seems to be ok now. Thanks!

Note: See TracTickets for help on using tickets.