BMP Translator. The alpha value is lost.

[bxi07354@…]

BMPTranslator.cpp

translate_from_bmpnpal_to_bits()

for (uint32 i = 0; i < msheader.width; i++) {

• memcpy(pBitsPixel, pBmpPixel, 3);

+ memcpy(pBitsPixel, pBmpPixel, bmpBytesPerPixel);

pBitsPixel += 4; pBmpPixel += bmpBytesPerPixel;

}

[jackburton]

Can somebody look into this ? I am not really into that kind of stuff...

[jackburton]

BTW, translate_from_bmppal_to_bits() seems to be broken in a similar way

[jackburton]

Could this also be the cause of #219 ?

[bxi07354@…]

sample image preferences/menu CTL and ALT

[bxi07354@…]

BBitmap dump

[marcusoverhagen]

I'll try to fix that

[stippi]

I'm just looking at the BMP translator right now and it is really poorly written with regards ot performance. memcpy(..., ..., 3) in the innermost loop everywhere. That's really bad. I've also come across clearing out the destination buffer with zeros and then filling it with pixel data in the next loop. Completely unnecessary.If the translator returns B_RGB32, then it is not expected to set the last byte (alpha), but if it is returning B_RGBA32, then it is expected to write alpha.I don't know enough about BMP to know if it actually supports alpha (but I would assume it does). The translator needs a complete overhaul.

[jackburton]

Looks like this bug has been fixed. At least the Menu app shows its bitmaps correctly.

[bxi07354@…]

Thanks. It became beautiful.

It is anxious for a moment. translate_from_bits_to_bmp24() {

.....

if (fromspace == B_CMAP8) {

pmap = system_colors();

• if (!pmap)

+ if (!pmap) { + delete[] bmpRowData; + delete[] bitsRowData

return B_ERROR;

+ }

}