Opened 15 years ago
Closed 15 years ago
#4036 closed bug (fixed)
[patch] GCC2 packages added to GCC4 hybrid instead of available GCC4 packages
| Reported by: | jprostko | Owned by: | anevilyak |
|---|---|---|---|
| Priority: | normal | Milestone: | R1 |
| Component: | Build System | Version: | R1/pre-alpha1 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
With a GCC4/2 hybrid, I noticed that builds including the optional packages of BezillaBrowser, KeymapSwitcher, and Vim all include the GCC 2 version of the respective apps, even when the GCC4 version is available. This is due to an unnecessary isHybridBuild check in OptionalPackages for these apps.
Attached is a diff to make sure the GCC4 version of the apps is included in this case. This way if it's a pure GCC4 build, or a GCC4/2 hybrid, the GCC4 version of the app is added. If it's a GCC2 or GCC2/4 hybrid, the GCC2 version will be added.
Attachments (1)
Change History (4)
by , 15 years ago
| Attachment: | OptionalPackages.diff added |
|---|
comment:1 by , 15 years ago
| Summary: | GCC2 apps added to GCC4/2 image when GCC4 version is available → [patch] GCC2 packages added to GCC4 hybrid instead of available GCC4 packages |
|---|
I forgot to mention that at the time this ticket was first submitted, it was revision 31158. This would be obvious from looking at the diff, but I wanted to explicitly state it here.
comment:2 by , 15 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
Applied with some other cleanups in hrev32063. Thanks!
comment:3 by , 15 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Patch to include GCC4 apps over GCC2 apps when relevant and available