Opened 10 years ago

Closed 10 years ago

#5419 closed bug (invalid)

PPC: PATCH: Playing catch up to new x86 VMTranslationMap

Reported by: kallisti5 Owned by: axeld
Priority: normal Milestone: R1/alpha2
Component: System/Kernel Version: R1/Development
Keywords: Cc: andreas.faerber@…
Blocked By: Blocking:
Has a Patch: no Platform: PowerPC

Description

see attached patch. Makes PPC more like x86, stubs out some missing methods.

This doesn't solve the problem in #5275 but will make it easier to solve in the future.

Attachments (1)

VMTranslationMap-cleanup-ppc.diff (6.0 KB ) - added by kallisti5 10 years ago.

Download all attachments as: .zip

Change History (2)

by kallisti5, 10 years ago

comment:1 by bonefish, 10 years ago

Resolution: invalid
Status: newclosed

Besides that the patch introduces style violations (spacing between functions) it also removes functionality. UnmapPages() and UnmapArea() have been omitted on purpose, since the base class provides (slow) fallback implementations. Adding ProtectPage() and ProtectArea() is utterly pointless, since they aren't virtual and the base class implements them inline in the header.

BTW, the reason for the X86VMTranslationMap class to have its own header is that the class is used outside arch_vm_translation_map.cpp, which, at least ATM, does not apply to the PPC implementation. So I would leave it were it is.

Note: See TracTickets for help on using tickets.