[Vision] crashes wrt ListView

[johndrinkwater]

After changing channels/servers a few times, Vision crashed with :

[Switching to team ./Vision (244) thread w>Freenode - [calvino.freenode. (272)] 0x003ebd9a in BListItem::IsSelected () from /boot/beos/system/lib/libbe.so (gdb) bt #0 0x003ebd9a in BListItem::IsSelected () from /boot/beos/system/lib/libbe.so #1 0x003efc7a in BListView::_CalcLastSelected ()

from /boot/beos/system/lib/libbe.so

#2 0x003efa45 in BListView::_DeselectAll ()

from /boot/beos/system/lib/libbe.so

#3 0x003ef381 in BListView::_Select () from /boot/beos/system/lib/libbe.so #4 0x003ee3f0 in BListView::Select () from /boot/beos/system/lib/libbe.so #5 0x002e4c9c in WindowList::MouseDown () #6 0x0042d85f in BWindow::DispatchMessage ()

from /boot/beos/system/lib/libbe.so

#7 0x00431054 in BWindow::task_looper () from /boot/beos/system/lib/libbe.so #8 0x003b3edb in BLooper::_task0_ () from /boot/beos/system/lib/libbe.so #9 0x0081fa10 in thread_entry () from /boot/beos/system/lib/libroot.so #10 0x700c1fec in ?? () (gdb)

[jackburton]

Let's see what anevilyak says about this one...

[anevilyak]

A little more information please...did you add/remove any channels or collapse any servers? Or are you just clicking back and forth between the server and a channel? At first glance it looks like it's possibly a bug somewhere in the binary searching stuff but need a bit more information to try and replicate it.

[anevilyak]

Oops, wait. I just realized this wasn't a newly filed bug, that may well be an issue that's fixed by some of the rewrites I did, since I did catch a few crash bugs that I've since patched. Can you still replicate this problem?

[jackburton]

Replying to anevilyak:

Oops, wait. I just realized this wasn't a newly filed bug, that may well be an issue that's fixed by some of the rewrites I did, since I did catch a few crash bugs that I've since patched.

Yeah, that's why I reassigned this to you.

Can you still replicate this problem?

Only johndrinkwater would know.

[anevilyak]

Replying to jackburton:

Only johndrinkwater would know.

I'm hoping he answers indeed...the main crash I remember fixing had to do with add/removing stuff to the view, since it was possible to trip a bug in BListView's quicksort implementation that would cause it to run off the end of the array. That may have affected other things, but I wouldn't have expected selecting items to be one of them, and haven't seen that crash myself. But who knows what the listview code looked like 2 years ago :)

[anevilyak]

As far as I'm aware this one is fixed.