Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#574 closed bug (fixed)

[Deskbar] edges are not drawn correctly when docked at the bottom

Reported by: j_freeman@… Owned by: jackburton
Priority: low Milestone: R1
Component: - General Version:
Keywords: Cc: diver
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Dock the Deskbar at the bottom of your screen, and you will see the top edge, where team buttons are not present, is not correctly drawn in 3D as it is in R5.

Tested in revision 17370 (and many, many previous ones) under VMware and real hardware, in various video modes and colorspaces.

Attachments (1)

deskbar.png (7.4 KB) - added by j_freeman@… 13 years ago.
Illustration

Download all attachments as: .zip

Change History (14)

comment:1 Changed 13 years ago by j_freeman@…

severity: normaltrivial

comment:2 Changed 13 years ago by j_freeman@…

Summary: [Deskbar] 3D edges are not drawn correctly when docked at the bottom[Deskbar] edge is not drawn correctly when docked at the bottom

Changed 13 years ago by j_freeman@…

Attachment: deskbar.png added

Illustration

comment:3 Changed 13 years ago by j_freeman@…

Summary: [Deskbar] edge is not drawn correctly when docked at the bottom[Deskbar] edges are not drawn correctly when docked at the bottom

comment:4 Changed 13 years ago by j_freeman@…

Another note: The bottom edge isn't even drawn; at least the top edge is drawn (just with the wrong color). This is also shown in the illustration attached.

comment:5 Changed 13 years ago by diver

Cc: diver added

comment:6 Changed 13 years ago by jackburton

Owner: changed from axeld to jackburton

comment:7 Changed 13 years ago by jackburton

I think I found out what's wrong: BMenuBar uses BMenu::Draw() to draw the menubar, and our version of it doesn't draw the border around the menu frame, because we let the menuwindow handle it. We should probably change (back) the menuwindow's look to B_NO_BORDER_WINDOW_LOOK and change the menu drawing code to draw the border itself. I can do that.

comment:8 Changed 13 years ago by jackburton

Component: ServersKits

comment:9 Changed 13 years ago by axeld

Yes, please, that sounds like the best solution :-)

comment:10 Changed 13 years ago by jackburton

Status: newassigned

comment:11 Changed 13 years ago by jackburton

Fixed in hrev18459

comment:12 Changed 13 years ago by jackburton

Resolution: fixed

comment:13 Changed 13 years ago by jackburton

Status: assignedclosed
Note: See TracTickets for help on using tickets.