Opened 12 years ago

Closed 2 years ago

Last modified 21 months ago

#5785 closed bug (fixed)

Show optional packages non-functional

Reported by: mmadia Owned by: pulkomandy
Priority: normal Milestone: R1/beta2
Component: Applications/Installer Version: R1/Development
Keywords: Cc: planche2k@…
Blocked By: Blocking: #5805, #11267, #15113
Platform: All

Description

With <volume>/_packages_/*.zip in place before running Installer, the packages do not display. Eg, on my machine both /boot (36432-r1a2-rc) and /generated have _packages/*.zip. To note, 36432-r1a2-rc is the initially selected source volume when running Installer.

When the packages view is collapsed, selecting /generated and then expanding it will yield no result. eg, screenshot1.png

When that view is expanded, the view appears to be updated and contain text, but it is not properly drawn. eg, screenshot2.png

Attachments (2)

screenshot1.png (156.0 KB ) - added by mmadia 12 years ago.
screenshot2.png (148.4 KB ) - added by mmadia 12 years ago.

Download all attachments as: .zip

Change History (15)

by mmadia, 12 years ago

Attachment: screenshot1.png added

by mmadia, 12 years ago

Attachment: screenshot2.png added

comment:1 by andreasf, 12 years ago

Cc: planche2k@… added

Noticed the lack of optional packages in hrev36100 and hrev36339 CDs' Installer, too.

comment:2 by korli, 12 years ago

Did you have a look at how _packages_ is filled on a BeOS CD ? I remember directories with attributes like "INSTALLER PACKAGE: NAME", etc.

comment:3 by mmadia, 12 years ago

Here's a table from BeTips.net and looking at an R5 Pro CD

type id name data
cstr attr INSTALLER PACKAGE: NAME ex. BeShare
cstr attr INSTALLER PACKAGE: DESCRIPTION What this does
cstr attr INSTALLER PACKAGE: GROUP ex. Net Tools
offt attr INSTALLER PACKAGE: SIZE size in bytes
bool attr INSTALLER PACKAGE: ON_BY_DEFAULT false or true
bool attr INSTALLER PACKAGE: ALWAYS_ON false or true

But, I'm not sure how this is handled wrt our cd-image type, isCDPackage, and Installer. From what I can tell, when the type is cd-image & an optionalpackage sets isCDPackage = true, the archive is simply copied into _packages_/, without getting any attributes. How Installer picks this up as something to be automatically extracted during installation is fuzzy.

I'll look into creating something like _packages_/Sources with the proper attributes.

comment:4 by stippi, 12 years ago

Yes, Installer CopyEngine just unzips everything in _packages_. Programmer laziness detected. I've made sure that all packages extract to the same destination, i.e. /boot and hard-coded this in Installer. If we want to enable the user selection process of which packages get installed, we need to work on Installer. I would say that packages which depend on other packages are left out of the optional ones at all (i.e. get installer regardless and are not displayed as optional). The distinction could be the presence of certain attributes. I could probably look into all this starting next week.

in reply to:  4 comment:5 by mmadia, 12 years ago

Replying to stippi:

Yes, Installer CopyEngine just unzips everything in _packages_. ... I could probably look into all this starting next week.

Feel free to assign jam related tasks to me.

comment:6 by mmadia, 8 years ago

Perhaps Installer could be updated to be HPKG friendly?

_packages_/*.hpkg is parsed for Name, Description, size, etc. Installer would then be able to simply relocate the selected hpkg's on the target destination from /_packages_ to the appropriate packages directory.

comment:7 by diver, 7 years ago

Blocking: 11267 added

comment:8 by waddlesplash, 3 years ago

Blocking: 15113 added

comment:9 by pulkomandy, 2 years ago

Blocking: 5805 added

comment:11 by pulkomandy, 2 years ago

Owner: changed from korli to pulkomandy
Status: newin-progress

comment:12 by pulkomandy, 2 years ago

Resolution: fixed
Status: in-progressclosed

Fixed in hrev53865.

We still don't ship any packages by default, but that will be addressed in #14310.

comment:13 by nielx, 21 months ago

Milestone: R1R1/beta2

Assign tickets with status=closed and resolution=fixed within the R1/beta2 development window to the R1/beta2 Milestone

Note: See TracTickets for help on using tickets.