Opened 10 years ago

Closed 10 years ago

#5850 closed enhancement (fixed)

Terminal localization patch

Reported by: Karvjorm Owned by: stippi
Priority: normal Milestone: R1
Component: Applications/Terminal Version: R1/alpha1
Keywords: Terminal localization ISO 8859-15 Cc: Karvjorm
Blocked By: Blocking:
Platform: All



I did not have mentioned that I have previously developed embedded systems programming applications (9 years) using Neuro C language. It is a subset of C with some communication objects. Also I have maintained an embedded C++ application running in Intel386 EX processors, if I recall it correct.

I have here a Terminal localization patch. PLS, can somebody delivery it to hta and make necessary modifications for implementation?

BTW, could somebody also add ISO 8859-15 support for Terminal: ? It replaced ISO 8859-1 when Euro symbol was needed.

Attachments (2)

TerminalLocalizationRevision36520.patch (24.2 KB ) - added by Karvjorm 10 years ago.
Localization patch for the Terminal application
TerminalLocalization2.patch (25.0 KB ) - added by Karvjorm 10 years ago.
A fixed Terminal localization patch

Download all attachments as: .zip

Change History (4)

by Karvjorm, 10 years ago

Localization patch for the Terminal application

comment:1 by stippi, 10 years ago

Owner: changed from jackburton to stippi
Status: newin-progress

Patch looks mostly good. A few things you could fix:

src/apps/terminal/Shell.cpp:515/519, the part "alert --stop" should not be part of the translated string, otherwise it's too easy to break the functionality in translations. That is unless we want to translate command line options for apps like alert. ;-)

src/apps/terminal/TermView.cpp:1857, can you change the string "Secondary Mouse Button Drop Menu" to "Secondary mouse button drop menu"? We changed most strings in Haiku to sentence case a while back. This string won't usually be seen by users, since it's the internal name of the menu, but it's possible to see it as window title for example in ProcessController.

Lastly, I am missing an important detail. Somewhere you should have a BCatalog fAppCatalog variable declared, most probably in the Terminal BApplication class and load it at init time. Without this, Terminal should crash.

Thanks a lot for the work, I will be happy to submit it with the above changes! :-)

by Karvjorm, 10 years ago

Attachment: TerminalLocalization2.patch added

A fixed Terminal localization patch

comment:2 by stippi, 10 years ago

Resolution: fixed
Status: in-progressclosed

Applied in hrev36640 and hrev36641. Please have a look at hrev36641, so you can make the appropriate changes to the Jamfile yourself next time. Thanks!

Note: See TracTickets for help on using tickets.