Attachments (2)
Change History (9)
comment:1 by , 19 years ago
comment:3 by , 17 years ago
| Platform: | → All |
|---|
The patch definitely improves the situation, however it is not entirely correct, either. Since the ascent and descent are the maximal height of the font, you would need to ceilf() either of them individually. As you can see, the SetHeight() call after your changes does it incorrectly as well. You should also ceil() or floor() the leading/2 and double that exact value for SetHeight(). Do you want to do these changes and apply another patch, or should I rework your patch and commit it?
comment:4 by , 17 years ago
| Cc: | added |
|---|---|
| Component: | - General → Kits/Kernel Kit |
cl21, could you take a look at this bug again?
comment:5 by , 17 years ago
Axel, do you mean like this (see attached patch)? When testing this it does not look right to me for characters with a lot of descent such as "q". They do not seem to have enough space underneath.
comment:6 by , 17 years ago
| Component: | Kits/Kernel Kit → Kits/Interface Kit |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Thanks for the patch! Fixed in hrev23046. I've changed the patch a bit as I shared your experience - even though it may not be as mathematically accurate than your version, at least it now looks best.
You mean the text should be centered vertically in the selection box, right? (just to be sure :-))