WindowLayer::IsNormal() crash

[johndrinkwater]

app_server crashes in WindowLayer::IsNormal() with a Bad thread ID

Steps to reproduce: 1, load MrPeeps, and close it 2, load MrPeeps, and app_server should jump to fullscreen debug

It happens irregularly, so try to start MrPeeps again if it doesn't happen.

[johndrinkwater]

Note: this happens more often when you do not have people in your ~/people/ dir

[diver]

Could this be somewhat connected to #653 ?

[axeld]

Thanks, I could reproduce this very well. Fixed in hrev17878.

[johndrinkwater]

Diver, I hadn't found your bug on search because this was bad thread id, and not a segment violation, but maybe the same - the backtrace is nearly identical (with the exception of an additional Desktop::ActivateWindow), so it's possible. Best to retest.

[axeld]

John, I'm afraid you're wrong here: "Bad thread ID" just means that GDB had some problems, the fault itself was a segment violation. "Bad thread ID" is just a standard error code.

[johndrinkwater]

Fair enough Axel (thankyou!), i'm still learning :) Does GDB lose all sense that it is a segment violation then? (will retest in a min)

[axeld]

I don't know, it could be that it doesn't see the actual cause in this case, you'd have to ask Ingo if you want to know more :-)