Opened 9 years ago

Last modified 10 months ago

#6987 reopened bug

InfoWindow Owner clipped in layout

Reported by: Karvjorm Owned by: aldeck
Priority: normal Milestone: R1
Component: Applications/Tracker Version: R1/Development
Keywords: Owner layout Cc: Karvjorm
Blocked By: Blocking: #14870
Has a Patch: no Platform: All

Description

As shown in the enclosed picture, "Owner" is clipped when it is shown with a localized text that is a bit longer than orginal in InfoWindow.

I tried to write a patch to resolve this problem, but because my development environment is broken (can't svn update the whole svn tree [due to a VMware virtual machine environment and a USB stick disk for it, I suppose]), I was not able to test it.

I enclosing here also a typo patch and another missing localization patch.

Attachments (6)

Owner.png (13.0 KB ) - added by Karvjorm 9 years ago.
A clipped and localized InfoWindow "Owner" text
InfoWindow.patch (972 bytes ) - added by Karvjorm 9 years ago.
Trying to solve a text clipping problem in a localized text.
FilePermissionView.patch (3.9 KB ) - added by Karvjorm 9 years ago.
Two missing localization texts
NodeWalker.patch (376 bytes ) - added by Karvjorm 9 years ago.
Typo in comment
infowindow.png (55.6 KB ) - added by diver 3 years ago.
user-group-other.png (3.7 KB ) - added by humdinger 3 years ago.
3 icons

Download all attachments as: .zip

Change History (29)

by Karvjorm, 9 years ago

Attachment: Owner.png added

A clipped and localized InfoWindow "Owner" text

by Karvjorm, 9 years ago

Attachment: InfoWindow.patch added

Trying to solve a text clipping problem in a localized text.

by Karvjorm, 9 years ago

Attachment: FilePermissionView.patch added

Two missing localization texts

by Karvjorm, 9 years ago

Attachment: NodeWalker.patch added

Typo in comment

comment:1 by Karvjorm, 9 years ago

Sorry, I mixed the comments of the two first comments.

comment:2 by anevilyak, 9 years ago

Owner: changed from anevilyak to aldeck
Status: newassigned

comment:3 by humdinger, 9 years ago

Blocking: 7295 added

(In #7295) You're right. Closing as duplicate.

comment:3 by humdinger, 9 years ago

Blocking: 7295 removed

The localization in InfoWindow.patch includes spaces, which can trip up translations at HTA.
FilePermissionView.patch doesn't solve the issue. I applied it locally, but the labels are still truncated, the column labels are now just as wide as a checkbox. This is hrev40612.

comment:4 by diver, 8 years ago

Component: Kits/libtracker.soApplications/Tracker
Version: R1/alpha2R1/Development

comment:5 by dsjonny, 7 years ago

I think the best way would be the usage of the layout api, as was in the find window. And also the capacity string is looks like wrong. (Using 45710 nightly.)

comment:6 by pulkomandy, 4 years ago

Increasing the width of the columns will not look very nice for languages where the strings are quite long. I would suggest using 45° rotated text for the column headers instead?

comment:7 by pulkomandy, 3 years ago

Resolution: fixed
Status: assignedclosed

Fixed in hrev51189.

comment:8 by diver, 3 years ago

Resolution: fixed
Status: closedreopened

"Execution" is still cut off in Russian locale. As well as the first latter of rotated "Others" label.

by diver, 3 years ago

Attachment: infowindow.png added

comment:9 by diver, 3 years ago

Has a Patch: set

comment:11 by diver, 3 years ago

Has a Patch: unset

comment:12 by axeld, 3 years ago

I'm not too fond of the rotated text; I'd rather see wider columns.

Other options:

  • U G O as headers, with a legend (user, group, others).
  • 1. 2. 3. as headers, with a legend.
  • icons as headers, with a legend.
  • Put header in two rows (alternating).

comment:13 by diver, 3 years ago

BTW, Alt+p (to expand permission view) doesn't seem to work anymore.

in reply to:  12 comment:14 by dsjonny, 3 years ago

Replying to axeld:

I'm not too fond of the rotated text; I'd rather see wider columns.

Other options:

  • U G O as headers, with a legend (user, group, others).
  • 1. 2. 3. as headers, with a legend.
  • icons as headers, with a legend.
  • Put header in two rows (alternating).

Hi

I "vote" for icons.

in reply to:  12 ; comment:15 by humdinger, 3 years ago

Replying to axeld:

  • icons as headers, with a legend.

Like that idea best. Instead of a legend, how about tool tips for the icons?
I'd suggest the "x-person" filetype icon for "owner" and the "People" icon for "group". What to use for the "other" though?

in reply to:  13 ; comment:16 by humdinger, 3 years ago

Replying to diver:

BTW, Alt+p (to expand permission view) doesn't seem to work anymore.

Works here in hrev51192 (gcc2h), fwiw.

in reply to:  16 comment:17 by diver, 3 years ago

Replying to humdinger:

Works here in hrev51192 (gcc2h), fwiw.

Right, I was using it was an issue with VMware Fusion keyboard mapping. Works now! :)

in reply to:  15 comment:18 by humdinger, 3 years ago

Replying to humdinger:

I'd suggest the "x-person" filetype icon for "owner" and the "People" icon for "group". What to use for the "other" though?

Here's the above and a new ???-icon for the "other". These are 24px, don't look that nice in 16px...

3 icons

by humdinger, 3 years ago

Attachment: user-group-other.png added

3 icons

comment:19 by humdinger, 3 years ago

Has a Patch: set

comment:20 by humdinger, 3 years ago

Has a Patch: unset

comment:21 by diver, 10 months ago

Blocking: 14870 added

comment:22 by -Meanwhile-, 10 months ago

Sorry for the duplicate 14870...

'Put header in two rows (alternating)' seems like the second best solution to me (after the rotated text).

Last edited 10 months ago by -Meanwhile- (previous) (diff)
Note: See TracTickets for help on using tickets.