Opened 13 years ago
Closed 12 years ago
#7229 closed enhancement (fixed)
Missing Translators Add-Ons localizations
| Reported by: | Karvjorm | Owned by: | pulkomandy |
|---|---|---|---|
| Priority: | normal | Milestone: | R1 |
| Component: | Add-Ons/Translators/GIF | Version: | R1/alpha2 |
| Keywords: | GIFTranslator localization patch | Cc: | Karvjorm |
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
During Datatranslation testing I noticed that not all translators add-ons are localized completed. I have opened here a new ticket to collect all the missing patches (and figures showing missing strings). Here is the first one: GIFTranslator Add-Ons.
Attachments (9)
Change History (17)
by , 13 years ago
| Attachment: | gif-another-localization-update.patch added |
|---|
comment:1 by , 13 years ago
| patch: | 0 → 1 |
|---|
by , 13 years ago
| Attachment: | gifimages-translator.png added |
|---|
Missing localization strings of GIFTranslator
by , 13 years ago
| Attachment: | jpeg2000-another-localization.patch added |
|---|
Additional JPEG2000Translator localization patch
by , 13 years ago
| Attachment: | jpeg2000-missing-localizations.png added |
|---|
Missing localization strings of JPEG2000Translator
by , 13 years ago
| Attachment: | jpeg-translators-add-ons-localization.patch added |
|---|
Localization patch fixing duplicate about text (one was correct, another was not)
by , 13 years ago
| Attachment: | jpeg-translators-add-on-about-tab.png added |
|---|
Showing how the about text was only partly localized.
by , 13 years ago
| Attachment: | jpeg-translators-add-on-write-tab.png added |
|---|
Missing localized string in Write tab
by , 13 years ago
| Attachment: | jpeg-translators-add-on-read-tab.png added |
|---|
Missing localized string in Read tab
comment:2 by , 13 years ago
Something is still wrong when testing JPEGTranslator Add-Ons. For example, "Show warning messages" were shown in fi.catkeys file, but it is not visible in application. I had it in JPEGTranslator.h file and it was defined also in Jamfile, but was not visible in application.
comment:3 by , 13 years ago
1) Both JPEG and JPEG2000 patches were not applicable to current revision of sources. Please use the next time most actual source revision you can obtain;
2) Anyway I have re-factored some lines mentioned in your patches to improve the situation. Now it should work better. At least my current catalogs were loaded with this change; See hrev40565 for details;
3) I found the patch for GIF translator unacceptable because this add-on (and PPM one) use the deprecated data translators API with direct exporting of translatorName[] and translatorInfo[] variables. And filling it in run-time is a bad practice and looks like doesn't help. The only acceptable way I see - is to rewrite GIF nad PPM add-ons to modern translator's API.
So I propose you to polish your C++ skill with upgrading GIF and PPM transaltor add-ons to modern API. ;-)
comment:4 by , 13 years ago
Note that JPEG,JPEG2000 and RAW translators localization finally fixed in hrev40577.
comment:5 by , 13 years ago
With r1a3-rc-hrev42159, only the titles "StyledEdit files translator" and "TGA Image Translator" seem to remain not localized.
I've added a patch to localize both strings in STXTView.cpp and TGAView.cpp.
by , 13 years ago
| Attachment: | STXTView.cpp_TGAView.cpp.patch added |
|---|
Patch to localize title strings for STXT and TGA Translators.
comment:6 by , 12 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
STXTView patch looks excellent.
comment:8 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Additional GIFTranslator localization patch