Opened 10 years ago

Closed 9 years ago

#7229 closed enhancement (fixed)

Missing Translators Add-Ons localizations

Reported by: Karvjorm Owned by: pulkomandy
Priority: normal Milestone: R1
Component: Add-Ons/Translators/GIF Version: R1/alpha2
Keywords: GIFTranslator localization patch Cc: Karvjorm
Blocked By: Blocking:
Platform: All

Description

During Datatranslation testing I noticed that not all translators add-ons are localized completed. I have opened here a new ticket to collect all the missing patches (and figures showing missing strings). Here is the first one: GIFTranslator Add-Ons.

Attachments (9)

gif-another-localization-update.patch (2.0 KB ) - added by Karvjorm 10 years ago.
Additional GIFTranslator localization patch
gifimages-translator.png (58.9 KB ) - added by Karvjorm 10 years ago.
Missing localization strings of GIFTranslator
jpeg2000-another-localization.patch (4.3 KB ) - added by Karvjorm 10 years ago.
Additional JPEG2000Translator localization patch
jpeg2000-missing-localizations.png (123.7 KB ) - added by Karvjorm 10 years ago.
Missing localization strings of JPEG2000Translator
jpeg-translators-add-ons-localization.patch (7.0 KB ) - added by Karvjorm 10 years ago.
Localization patch fixing duplicate about text (one was correct, another was not)
jpeg-translators-add-on-about-tab.png (88.9 KB ) - added by Karvjorm 10 years ago.
Showing how the about text was only partly localized.
jpeg-translators-add-on-write-tab.png (84.7 KB ) - added by Karvjorm 10 years ago.
Missing localized string in Write tab
jpeg-translators-add-on-read-tab.png (34.8 KB ) - added by Karvjorm 10 years ago.
Missing localized string in Read tab
STXTView.cpp_TGAView.cpp.patch (3.4 KB ) - added by taos 9 years ago.
Patch to localize title strings for STXT and TGA Translators.

Download all attachments as: .zip

Change History (17)

by Karvjorm, 10 years ago

Additional GIFTranslator localization patch

comment:1 by Karvjorm, 10 years ago

patch: 01

by Karvjorm, 10 years ago

Attachment: gifimages-translator.png added

Missing localization strings of GIFTranslator

by Karvjorm, 10 years ago

Additional JPEG2000Translator localization patch

by Karvjorm, 10 years ago

Missing localization strings of JPEG2000Translator

by Karvjorm, 10 years ago

Localization patch fixing duplicate about text (one was correct, another was not)

by Karvjorm, 10 years ago

Showing how the about text was only partly localized.

by Karvjorm, 10 years ago

Missing localized string in Write tab

by Karvjorm, 10 years ago

Missing localized string in Read tab

comment:2 by Karvjorm, 10 years ago

Something is still wrong when testing JPEGTranslator Add-Ons. For example, "Show warning messages" were shown in fi.catkeys file, but it is not visible in application. I had it in JPEGTranslator.h file and it was defined also in Jamfile, but was not visible in application.

comment:3 by siarzhuk, 10 years ago

1) Both JPEG and JPEG2000 patches were not applicable to current revision of sources. Please use the next time most actual source revision you can obtain;

2) Anyway I have re-factored some lines mentioned in your patches to improve the situation. Now it should work better. At least my current catalogs were loaded with this change; See hrev40565 for details;

3) I found the patch for GIF translator unacceptable because this add-on (and PPM one) use the deprecated data translators API with direct exporting of translatorName[] and translatorInfo[] variables. And filling it in run-time is a bad practice and looks like doesn't help. The only acceptable way I see - is to rewrite GIF nad PPM add-ons to modern translator's API.

So I propose you to polish your C++ skill with upgrading GIF and PPM transaltor add-ons to modern API. ;-)

comment:4 by siarzhuk, 10 years ago

Note that JPEG,JPEG2000 and RAW translators localization finally fixed in hrev40577.

comment:5 by taos, 9 years ago

With r1a3-rc-hrev42159, only the titles "StyledEdit files translator" and "TGA Image Translator" seem to remain not localized.

I've added a patch to localize both strings in STXTView.cpp and TGAView.cpp.

by taos, 9 years ago

Patch to localize title strings for STXT and TGA Translators.

comment:6 by lodewijkadlp, 9 years ago

Owner: changed from nobody to pulkomandy
Status: newassigned

STXTView patch looks excellent.

comment:7 by pulkomandy, 9 years ago

Applied in hrev43001. Thanks!

comment:8 by pulkomandy, 9 years ago

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.