Opened 8 years ago

Closed 8 years ago

#7643 closed enhancement (invalid)

[AboutSystem] Change window title to About Haiku

Reported by: deejam Owned by: leavengood
Priority: normal Milestone: R1
Component: Applications/AboutSystem Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

"About this system" is renamed to "About Haiku" in Deskbar. Window title should be renamed to "About Haiku" to match the Deskbar name. Maybe the whole component should be renamed to "AboutHaiku" (the binary and sources).

r1a3rc-hrev41884.

Attachments (3)

about_system.png (42.7 KB) - added by deejam 8 years ago.
ticket7643.patch (822 bytes) - added by Miroslav-Stimac 8 years ago.
This patch just changes the name of the window.
de.catkeys (10.3 KB) - added by Miroslav-Stimac 8 years ago.
The associated German catalog file. I added the translation.

Download all attachments as: .zip

Change History (14)

Changed 8 years ago by deejam

Attachment: about_system.png added

comment:1 Changed 8 years ago by leavengood

Owner: changed from nobody to leavengood
Status: newassigned

Take ownership for when Miroslav attaches his patch.

comment:2 Changed 8 years ago by axeld

Before we apply this, or even take this into account: AboutSystem once was named AboutHaiku, and there was quite some discussion which ended in us renaming it to AboutSystem (IIRC to make it easier for distributions, but also because our system directory is called "system", not "haiku").

So before anything is done here prematurely, this topic should be brought up again on the mailing list.

comment:3 Changed 8 years ago by tonestone57

I prefer it stay About System. Bring it up on the mailing list before making changes.

On Windows XP they call it System Properties. Not About Windows.

I kinda see the point but About This System is able to describe the left and right sides. The right side is about copyright & contributors and the left side is about the system (what processor, memory amount, kernel compile date & Haiku revision). Processor, memory and time running info describe the system itself and not Haiku! Naming to About Haiku means those three would not make sense being listed in this window.

Name could change to System Info, System Details, About System, etc., going from 3 words down to 2 with one of them still being System

comment:4 Changed 8 years ago by leavengood

Yeah I had the thought that we had discussed this before, and that it was partially related to Haiku "distros", though tonestone makes a good point too. I think we should just leave it as is and if anything rename the Deskbar side to match this.

Changed 8 years ago by Miroslav-Stimac

Attachment: ticket7643.patch added

This patch just changes the name of the window.

comment:5 Changed 8 years ago by Miroslav-Stimac

Has a Patch: set

Changed 8 years ago by Miroslav-Stimac

Attachment: de.catkeys added

The associated German catalog file. I added the translation.

comment:6 Changed 8 years ago by Miroslav-Stimac

I changed the name of the window and added the German catalog file. I did not change the name of the binary file and I do not recommend to change it because perhaps some external applications link or start the AboutSystem application and if we change the name or location of the binary file, then incompatibility problems may occur.

Last edited 8 years ago by Miroslav-Stimac (previous) (diff)

comment:7 Changed 8 years ago by leavengood

Hi Miroslav,

Thanks for the patch, it looks correct as far as solving this ticket. But as you may see from other comments, it seems the entire ticket may be invalid since we actually want AboutSystem to be called AboutSystem. I need to see what the wording is in Deskbar, as that actually may be what needs changing in this case.

In other words, sorry, but your patch is probably not needed. But at least you learned about the patch process.

comment:8 Changed 8 years ago by Miroslav-Stimac

Yes, I learnt about the patch process and this was a nice start and easy task. I will try to find some other simple tickets and learn how to program Haiku.

comment:9 Changed 8 years ago by leavengood

Miroslav,

Two tickets which are in my list which you may wish to try fixing are #6766 and #7219. I'm pretty sure they are valid tickets, though my rule is always to confirm a ticket before working on it (well how then do you know it is fixed?)

Ticket #6766 is probably pretty easy and I am sure other applications do this already with their save panels. Maybe take a look at StyledEdit or other applications which use save panels. It probably is just a matter of saving the last chosen directory for saving or opening as a setting which is reloaded when the app is started.

For #7219 you should remove the hard-coded icons and make use of the BIconUtils class to get default icons to use. There are various examples around the code for use of BIconUtils, such as the FileTypes preference app, or even the Icons screensaver.

If those don't interest you, I'm sure there are many others :)

You can also look at tickets marked easy.

comment:10 Changed 8 years ago by tonestone57

Well this ticket could still be valid but must be discussed on the developer mailing list first to see what other developers think before making changes one way or another.

On deskbar menu it says "About Haiku"
In the window it says "About this system"

ie, does not appear to be consistent which normally is a bad thing though I do not mind it here because that window is really two parts put together - About System (left) & About Haiku (right) =)

So having About Haiku in deskbar & About System in the window seems fine to me at least.

comment:11 Changed 8 years ago by leavengood

Resolution: invalid
Status: assignedclosed

After further thought I think the status quo is fine.

AboutSystem is about the system and also about Haiku, so its name is good. Yet the name in the Deskbar ("About Haiku") is also appropriate since the primary "question" being answered when users click it is "What is Haiku about?"

Closing this ticket.

Note: See TracTickets for help on using tickets.