Opened 8 years ago

Closed 5 years ago

#8240 closed bug (fixed)

WebPositive - Download folder can be explicitly set to a nonexistent folder

Reported by: riktov Owned by: aldeck
Priority: normal Milestone: R1
Component: Applications/WebPositive Version: R1/alpha3
Keywords: WebPositive download Cc: phoudoin, przemub@…
Blocked By: Blocking: #9053
Has a Patch: no Platform: All

Description

In WebPositive, the Download folder setting is an editable text field, so it can be set to a nonexistent folder. If so, starting a download will open the Downloads window but nothing gets downloaded, no progress on progress bar, and no error message.

On most browsers the Download folder is selectable through a file browser only.

Change History (7)

comment:1 Changed 8 years ago by umccullough

Even if it's switched to a file browser, there will still need to be a way to gracefully handle a missing folder.

The user can still delete the selected folder after setting it, causing the same problem.

comment:2 Changed 8 years ago by phoudoin

I guess we should call create_directory with the user-specified Download folder path before starting any new WebDownload.

For the delete case, it's already handled: WebDownload monitor the node, and on delete notification the download is canceled. What's buggy is that we don't handle the missing folder case.

comment:3 Changed 7 years ago by phoudoin

Cc: phoudoin added

comment:4 Changed 7 years ago by phoudoin

Blocking: 9053 added

comment:5 Changed 7 years ago by phoudoin

Owner: changed from leavengood to aldeck
Status: newassigned

A patch hacking a solution in the GUI part was proposed in duplicate ticket #9053. But the fix should be done in WebKit/haiku/API/WebDownloadPrivate.cpp, findAvailableFilename() method, which is not under haiku source tree but webkit...

comment:6 Changed 7 years ago by przemub

Cc: przemub@… added

comment:7 Changed 5 years ago by pulkomandy

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.