Opened 9 years ago

Closed 5 years ago

#8451 closed enhancement (no change required)

acpi_cpuidle: try to decode cstate from acpi _CST

Reported by: yongcong Owned by: yongcong
Priority: normal Milestone: R1
Component: Drivers/ACPI Version: R1/alpha3
Keywords: gsoc2012 Cc:
Blocked By: Blocking:
Platform: All


we need to get c-states information from ACPI _CST table

Attachments (3)

0001-acpi_cpuidle-try-to-decode-cstate-from-acpi-_CST.patch (8.8 KB ) - added by yongcong 9 years ago.
0001-acpi_cpuidle-try-to-decode-cstate-from-acpi-_CST.2.patch (8.6 KB ) - added by yongcong 9 years ago.
syslog (185.1 KB ) - added by SeanCollins 9 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 by yongcong, 9 years ago

patch: 01

comment:2 by bonefish, 9 years ago

I'm not familiar with ACPI, so just a few general remarks:

  • In the Jamfile the SetSubDirSupportedPlatformsBeOSCompatible invocation and the $(TARGET_PLATFORM) != haiku block are superfluous. I don't think that anyone still develops this code on BeOS -- it probably doesn't even work there anymore.
  • Coding style: After the // leading a C++ comment there should be a space.
  • Preferred pointer style is type* foo instead of type *foo, though the code base is still rather mixed in this regard. New code should prefer the former, though.
  • Unless there's a good reason not to, make source files C++ files. Among other things this allows variable definitions to be moved to their initialization point and also results in better warnings.

comment:3 by yongcong, 9 years ago

fixed in the new the attached patch. Thanks bonefish

comment:4 by SeanCollins, 9 years ago

2 sucessful boot with this patch and 2 hours of uptime with various tasks and loads. Not sure what exactly its supposed to do aside from report cpu state and set state, but it doesn't seem to break anything.

by SeanCollins, 9 years ago

Attachment: syslog added

comment:5 by yongcong, 9 years ago

Hi SeanCollins and tqh,

Could we just hold on for this patch? This patch is one _CST test driver to learn how to write driver for haiku, how to call haiku acpi API and how to get _CST and can do nothing Now ;)

Thank you for all your help

comment:6 by mmadia, 9 years ago

Owner: changed from tqh to yongcong
Status: newassigned

comment:7 by pulkomandy, 5 years ago

Resolution: no change required
Status: assignedclosed

As mentionned by yongcong, this was just a test and there are no new features. The code is kept here for reference, but the ticket can be closed.

Note: See TracTickets for help on using tickets.