Opened 13 years ago
Closed 8 years ago
#8451 closed enhancement (no change required)
acpi_cpuidle: try to decode cstate from acpi _CST
Reported by: | yongcong | Owned by: | yongcong |
---|---|---|---|
Priority: | normal | Milestone: | R1 |
Component: | Drivers/ACPI | Version: | R1/alpha3 |
Keywords: | gsoc2012 | Cc: | |
Blocked By: | Blocking: | ||
Platform: | All |
Description
we need to get c-states information from ACPI _CST table
Attachments (3)
Change History (10)
by , 13 years ago
Attachment: | 0001-acpi_cpuidle-try-to-decode-cstate-from-acpi-_CST.patch added |
---|
comment:1 by , 13 years ago
patch: | 0 → 1 |
---|
comment:2 by , 13 years ago
by , 13 years ago
Attachment: | 0001-acpi_cpuidle-try-to-decode-cstate-from-acpi-_CST.2.patch added |
---|
comment:4 by , 13 years ago
2 sucessful boot with this patch and 2 hours of uptime with various tasks and loads. Not sure what exactly its supposed to do aside from report cpu state and set state, but it doesn't seem to break anything.
by , 13 years ago
comment:5 by , 13 years ago
Hi SeanCollins and tqh,
Could we just hold on for this patch? This patch is one _CST test driver to learn how to write driver for haiku, how to call haiku acpi API and how to get _CST and can do nothing Now ;)
Thank you for all your help
comment:6 by , 12 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:7 by , 8 years ago
Resolution: | → no change required |
---|---|
Status: | assigned → closed |
As mentionned by yongcong, this was just a test and there are no new features. The code is kept here for reference, but the ticket can be closed.
I'm not familiar with ACPI, so just a few general remarks:
SetSubDirSupportedPlatformsBeOSCompatible
invocation and the$(TARGET_PLATFORM) != haiku
block are superfluous. I don't think that anyone still develops this code on BeOS -- it probably doesn't even work there anymore.//
leading a C++ comment there should be a space.type* foo
instead oftype *foo
, though the code base is still rather mixed in this regard. New code should prefer the former, though.