Opened 7 years ago

Last modified 9 months ago

#8900 assigned enhancement

Design of Contextmenu

Reported by: Morbid Owned by: leavengood
Priority: normal Milestone: R1
Component: User Interface Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: x86

Description

Contextmenu on Desktop should be streched a little to the right and Shortcuts placed in one column behind the arrows. What do you think?

Attachments (5)

screenshot2.png (106.9 KB) - added by Morbid 7 years ago.
aligned_shortcuts.png (13.6 KB) - added by leavengood 7 years ago.
Shortcuts aligned
align_shortcuts_ticket_8900.patch (1.2 KB) - added by leavengood 7 years ago.
screenshot3.png (79.2 KB) - added by Morbid 7 years ago.
Just_like_this_Demo_Arrows.png (45.1 KB) - added by Morbid 6 years ago.

Download all attachments as: .zip

Change History (25)

Changed 7 years ago by Morbid

Attachment: screenshot2.png added

comment:1 Changed 7 years ago by anevilyak

Type: bugenhancement

comment:2 Changed 7 years ago by leavengood

Owner: changed from stippi to leavengood
Status: newassigned

You are just suggesting leaving the space for the submenu arrow when there is no submenu so that all the shortcuts are in the same column? That seems reasonable and should be easy enough. I'll take a look at this after our alpha4 release is done.

comment:3 Changed 7 years ago by leavengood

Well turns out this was stupidly easy. See the following attachment.

Changed 7 years ago by leavengood

Attachment: aligned_shortcuts.png added

Shortcuts aligned

comment:4 Changed 7 years ago by leavengood

But I'm not sure how much I like it. Other platforms that I've just looked at (Ubuntu and OS X) don't seem to leave this space.

comment:5 Changed 7 years ago by Morbid

For me it looks a little more professional! Did'nt try Ubuntu and OS X! Maybe we have to ask other guys about it. But i don't want to make an elephant out of a fly. LOL "professional" was the wrong word, sorry for that. "Elegant" is the right word.

Last edited 5 years ago by Morbid (previous) (diff)

comment:6 Changed 7 years ago by leavengood

I can't speak for all Haiku developers, but for me the small things matter so I'm fine with these sort of suggestions.

What is unique to Haiku compared to those other systems is menu items which have both a shortcut and a submenu, and I think this change makes sense when you consider that. In fact that is why that menu might look a bit strange normally.

But looking around the system with this change I see a few issues (menu items which don't look as good) so I'll hold off for now until after the release.

comment:7 Changed 7 years ago by leavengood

So I don't lose it, here is the patch which fixes this, including fixing the alignment issues I mentioned in my last comment.

Changed 7 years ago by leavengood

comment:8 Changed 7 years ago by leavengood

Has a Patch: set

comment:9 Changed 7 years ago by Morbid

Thanks again!

comment:10 Changed 7 years ago by axeld

I would say the spacing should only appear if there is any sub menu, otherwise, I could imagine this won't look as good. I like the changed alignment better in any case, though.

comment:11 Changed 7 years ago by Morbid

Ok! And what do you think about the Arrows! I like the Arrows in Tracker-Menu! See Screenschot!

Changed 7 years ago by Morbid

Attachment: screenshot3.png added

comment:12 Changed 7 years ago by axeld

What are you talking about? The arrows didn't change or did I miss something.

comment:13 Changed 7 years ago by Morbid

Last edited 6 years ago by Morbid (previous) (diff)

Changed 6 years ago by Morbid

comment:14 Changed 6 years ago by x-ist

Has a Patch: unset

My two cents:

  • I find the proposed alignment looks more tidy and improves readability (much like with good codestyle).
  • As axeld said, the spacing should appear in case there are submenus only.
  • The arrows from the demo pic are less intrusive and steal less attention, which I find better too, as the menu item text deserves the primary focus.

comment:15 Changed 6 years ago by Morbid

Thanks for commenting and to engage with my "cry's"! I know there are other Problems witch are more important to solve. If i may say this here: Great OS and big THANKS for HAIKU.

comment:16 Changed 6 years ago by umccullough

Has a Patch: set

reset "patch" flag that got turned off by accident

comment:17 Changed 6 years ago by mmadia

Any status updates on this patch?

comment:18 Changed 6 years ago by leavengood

I just didn't keep up with Haiku development for a while.

As seen from the patch the basic implementation is pretty simple. It would be a bit more complicated to only do the padding if there are submenus anywhere on the given menu, but I can probably get it to work.

comment:19 Changed 9 months ago by pulkomandy

comment:20 Changed 9 months ago by pulkomandy

Has a Patch: unset
Note: See TracTickets for help on using tickets.