64 bit MediaPlayer crashes on some AVI videos

[vidrep]

hrev50095 x86_64 Some AVI format video files will cause MediaPlayer to crash These same files previously would play with ffmpeg 0.11.5 and stopped working with the update to ffmpeg 2.8 Attached is a short sample clip which will cause a crash

[vidrep]

The sample clip attached will play normally on 32 bit Haiku.

[vidrep]

I tested hrev50101 x86_64 today using the new ffmpeg 3.0. It behaves in exactly the same manner as previous ffmpeg revisions.

[vidrep]

This is a duplicate of one of my earlier tickets #11617. The older one can be closed and referenced.

[korli]

This one crashes reliably :) What happens is: Video decoding fails because of #12731, which in turn triggers an assert in ffmpeg, calling abort(). The media extractor thread is still running and tries to call some BBufferIO method, which is already unloaded, thus the pure virtual method call. Whether resolving #12731 is enough to avoid crashing isn't sure.

[korli]

Video decoding doesn't fail because of #12731: It seems we try to map B_YCbCr422 to a ffmpeg pixel format, but the mapping doesn't exist. B_YCbCr422 shouldn't be used as output colorspace when USE_SWS_FOR_COLOR_SPACE_CONVERSION is enabled. I think I'll make this change, and add some more checks or debugger() calls. This should also fix ogg files crashing on x86_64.

[vidrep]

Confirmed working again on hrev51295 x86_64. Close the ticket! Thank you!

[korli]

A Mediaplayer thread seems to crash on closing, but that's a minor problem.