Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#5996 closed bug (fixed)

[patch] menu navigation with keyboard fixes

Reported by: Ziusudra Owned by: axeld
Priority: normal Milestone: R1
Component: Kits/Interface Kit Version: R1/alpha2
Keywords: Cc: planche2k@…
Blocked By: Blocking: #5776
Has a Patch: no Platform: x86

Description

Fixes two issues:

  • opening a submenu and selecting the first item would open that item's submenu (if it had one) resulting in opening two submenus per key press
  • pressing left would not close the current submenu

Attachments (1)

Menu_keyboard_fixes.patch (957 bytes) - added by Ziusudra 9 years ago.

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by Ziusudra

Attachment: Menu_keyboard_fixes.patch added

comment:1 Changed 9 years ago by andreasf

Blocking: 5776 added
Cc: planche2k@… added

comment:2 Changed 9 years ago by stippi

Resolution: fixed
Status: newclosed

That code was fresh in my memory, since I've begun to try and rewrite it with a dedicated BMenuNavigator class... I've also tested it in Tracker. Mostly it works, there are some strange menus that won't open though, like the "Move To" menu, while "Copy To" works just fine... better than before in any case. Applied in hrev36819. Thanks!

comment:3 Changed 9 years ago by Ziusudra

Yeah, I have that problem with Deskbar; the Applications and Preferences submenus wont open. I don't have that problem with any of the toplevel Tracker submenus, but bin, include and lib in /boot/common/ wont open.

This bug is reported in #4930

Note: See TracTickets for help on using tickets.