Media Server crashing when shutting down/used with cortex/randomly with media files (float_to_float())

[stargatefan]

Was trying to use cortex to see if inputs and output worked. I was met with failure.

Thread 2492 caused an exception: Segment violation
[...]
[Switching to team /boot/system/servers/media_addon_server (2474) thread Audio Mixer control (2492)]
0x00956d89 in Resampler::float_to_float ()
   from /boot/system/add-ons/media/mixer.media_addon
(gdb) bt
#0  0x00956d89 in Resampler::float_to_float ()
   from /boot/system/add-ons/media/mixer.media_addon
#1  0x0095289f in MixerInput::BufferReceived ()
   from /boot/system/add-ons/media/mixer.media_addon
#2  0x00950222 in MixerCore::BufferReceived ()
   from /boot/system/add-ons/media/mixer.media_addon
#3  0x0094d58f in AudioMixer::HandleInputBuffer ()
   from /boot/system/add-ons/media/mixer.media_addon
#4  0x0094d5fa in AudioMixer::HandleEvent ()
   from /boot/system/add-ons/media/mixer.media_addon
#5  0x004c443b in BMediaEventLooper::DispatchEvent ()
   from /boot/system/lib/libmedia.so
#6  0x004c4ab7 in BMediaEventLooper::ControlLoop ()
   from /boot/system/lib/libmedia.so
#7  0x004c43a9 in BMediaEventLooper::_ControlThreadStart ()
   from /boot/system/lib/libmedia.so
#8  0x00657060 in thread_entry () from /boot/system/lib/libroot.so
#9  0x701c5fec in ?? ()
(gdb) 

[stargatefan]

Still seeing random crashs with media server at shut down. It also has trouble with files that may or may not have missing frames.

Problem seemed to drop up in the 402xx series IIRC.

I could try to narrow it down but it could just be a flue to. I have seen it on the nightlys to.

Easy to reproduce

Install nightly iso with hda, shut machine down.

gcc4 hybrid 40356

GNU gdb 6.3
Copyright 2004 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "i586-pc-haiku"...(no debugging symbols found)

[tcsetpgrp failed in terminal_inferior: Invalid Argument]
Thread 200 called debugger(): oops
Reading symbols from /boot/system/runtime_loader...done.
Loaded symbols for /boot/system/runtime_loader
Reading symbols from /boot/system/lib/libbe.so...done.
Loaded symbols for /boot/system/lib/libbe.so
Reading symbols from /boot/system/lib/libmedia.so...done.
Loaded symbols for /boot/system/lib/libmedia.so
Reading symbols from /boot/system/lib/libgame.so...done.
Loaded symbols for /boot/system/lib/libgame.so
Reading symbols from /boot/system/lib/libsupc++.so...done.
Loaded symbols for /boot/system/lib/libsupc++.so
Reading symbols from /boot/system/lib/libstdc++.so...done.
Loaded symbols for /boot/system/lib/libstdc++.so
Reading symbols from /boot/system/lib/libroot.so...done.
Loaded symbols for /boot/system/lib/libroot.so
Reading symbols from /boot/system/lib/libtracker.so...done.
Loaded symbols for /boot/system/lib/libtracker.so
Reading symbols from /boot/system/lib/libtranslation.so...done.
Loaded symbols for /boot/system/lib/libtranslation.so
Reading symbols from /boot/system/add-ons/media/firewire_dv.media_addon...done.
Loaded symbols for /boot/system/add-ons/media/firewire_dv.media_addon
Reading symbols from /boot/system/add-ons/media/hmulti_audio.media_addon...done.
Loaded symbols for /boot/system/add-ons/media/hmulti_audio.media_addon
Reading symbols from /boot/system/add-ons/media/mixer.media_addon...done.
Loaded symbols for /boot/system/add-ons/media/mixer.media_addon
[tcsetpgrp failed in terminal_inferior: Invalid Argument]
[Switching to team /boot/system/servers/media_addon_server (145) thread Audio Mixer control (200)]
0xffff0114 in ?? ()
(gdb) bt
#0  0xffff0114 in ?? ()
#1  0x006541db in debugger () from /boot/system/lib/libroot.so
#2  0x004bb80e in BBuffer::SetHeader () from /boot/system/lib/libmedia.so
#3  0x004bc840 in BBufferConsumer::HandleMessage ()
   from /boot/system/lib/libmedia.so
#4  0x004cac58 in BMediaNode::WaitForMessage ()
   from /boot/system/lib/libmedia.so
#5  0x004c597e in BMediaEventLooper::ControlLoop ()
   from /boot/system/lib/libmedia.so
#6  0x004c53a9 in BMediaEventLooper::_ControlThreadStart ()
   from /boot/system/lib/libmedia.so
#7  0x00658070 in thread_entry () from /boot/system/lib/libroot.so
#8  0x701c5fec in ?? ()
(gdb) GNU gdb 6.3

[pulkomandy]

(In #10344) the crash is in the resampler code. Switching from "linear interpolation" to "drop/repeat sample" is a safer way to avoid this problem (even for apps not generating 48kHz output). the drop/repeat code is ok, only the interpolated one is buggy (seem to do an out of bounds access from time to time).

Also, reopening this as a separate issue, the backtrace in #7180 isn't the same.

[pulkomandy]

(In #10344) Oops, you're right, I was looking at the stacktrace in the first comment there.

[pulkomandy]

And, @stargatefan: your problem is unrelated, if it still happens, please open a separate ticket.

[ttcoder]

Had that one occur reliably a few seconds after boot-up (not shutting down) after doing a sorta 'manual' upgrade to 47896 last week.. Once in int_to_float and the rest of the times in float_to_float(). Scared the heck out of me :-).. Now did a proper (pkgman) update to 47991 and audio works correctly. I always use drop/repeate samples BTW, never interpolation. Anyway I blame it on the cranky manual update, hope to never see this again :-)

[Barrett]

After my patch at #6188 this should be checked as the two bugs seems two effects of the same cause.

[Barrett]

Fixed in hrev49503.