Webkit: context menu items do not translate

[dsjonny]

The WebPositive's context menu always shows in English. This is the same for all HTML elements.

[dsjonny]

And the tab-bar's tooltips too.

[dsjonny]

I found the missing translations for the tab-bar's tooltips:

http://cgit.haiku-os.org/haiku/tree/src/apps/webpositive/tabview/TabContainerView.cpp?h=r1alpha4
line 472: fController->SetToolTip("Double-click or middle-click to open new tab.");

http://cgit.haiku-os.org/haiku/tree/src/apps/webpositive/tabview/TabManager.cpp?h=r1alpha4
line: SetToolTip("New tab (Cmd-T)");

The page's context menu is in the webcore library, but I did not found that source.

[jessicah]

You'll want to look at Source/WebCore/platform/haiku/ContextMenuItemHaiku.cpp. That seems to be where the actual menu items are added to the popup menu.

[dsjonny]

Thanks jessicah!

I found the strings in the "LocalizedStringsHaiku.cpp" file. And do I know this right we need only to add

#include "<Catalog.h>"

#define B_TRANSLATION_CONTEXT "WebPositive Page Context Menu"

to this file, and replace all

return "...";

to

return B_TRANSLATE("...");

?

If this is right, than one more ticket solved :)

I attach this file with these modifications.

[dsjonny]

I have added a patch for the localization. Please check it, because I'm not sure the jamfile is correct.

[mmadia]

CC'ing aldeck, in case he isn't on the haiku-bugs list.

[bitigchi]

Proposing milestone R1/beta3.