Opened 7 years ago

Last modified 7 years ago

#8956 new bug

Browser's context menu does not translate

Reported by: dsjonny Owned by: leavengood
Priority: normal Milestone: R1
Component: Applications/WebPositive Version: R1/Development
Keywords: Cc: aldeck
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

The WebPositive's context menu always shows in English. This is the same for all HTML elements.

Attachments (2)

LocalizedStringsHaiku.cpp (9.3 KB ) - added by dsjonny 7 years ago.
0001-Added-missing-localization-support-for-WebPositive-c.patch (9.0 KB ) - added by dsjonny 7 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 by dsjonny, 7 years ago

And the tab-bar's tooltips too.

comment:2 by dsjonny, 7 years ago

I found the missing translations for the tab-bar's tooltips:

http://cgit.haiku-os.org/haiku/tree/src/apps/webpositive/tabview/TabContainerView.cpp?h=r1alpha4
line 472: fController->SetToolTip("Double-click or middle-click to open new tab.");

http://cgit.haiku-os.org/haiku/tree/src/apps/webpositive/tabview/TabManager.cpp?h=r1alpha4
line: SetToolTip("New tab (Cmd-T)");

The page's context menu is in the webcore library, but I did not found that source.

Last edited 7 years ago by dsjonny (previous) (diff)

comment:3 by jessicah, 7 years ago

You'll want to look at Source/WebCore/platform/haiku/ContextMenuItemHaiku.cpp. That seems to be where the actual menu items are added to the popup menu.

comment:4 by dsjonny, 7 years ago

Thanks jessicah!

I found the strings in the "LocalizedStringsHaiku.cpp" file. And do I know this right we need only to add

#include "<Catalog.h>"

#define B_TRANSLATION_CONTEXT "WebPositive Page Context Menu"

to this file, and replace all

return "...";

to

return B_TRANSLATE("...");

?

If this is right, than one more ticket solved :)

I attach this file with these modifications.

by dsjonny, 7 years ago

Attachment: LocalizedStringsHaiku.cpp added

comment:5 by dsjonny, 7 years ago

Version: R1/alpha3R1/Development

comment:6 by dsjonny, 7 years ago

Has a Patch: set

comment:7 by dsjonny, 7 years ago

I have added a patch for the localization. Please check it, because I'm not sure the jamfile is correct.

comment:8 by mmadia, 7 years ago

Cc: aldeck added

CC'ing aldeck, in case he isn't on the haiku-bugs list.

Note: See TracTickets for help on using tickets.