Opened 12 years ago

Closed 12 years ago

#9058 closed bug (fixed)

[Trac] "Has a Patch" no longer working

Reported by: umccullough Owned by: nielx
Priority: high Milestone:
Component: Website/Trac Version:
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

It seems the "Has a Patch" functionality is no longer working properly in Trac.

The checkbox is there, but doesn't appear to be usable - furthermore, when someone comments on a ticket containing a patch, where "Has a Patch" is checked, it seems to uncheck it automatically.

Attachments (3)

configure-preview-limit-by-mimetype.diff​ (2.1 KB ) - added by nielx 12 years ago.
Test
hgshelve.py​ (21.1 KB ) - added by nielx 12 years ago.
Another test
ticket_9058_snip.PNG​ (12.8 KB ) - added by umccullough 12 years ago.

Download all attachments as: .zip

Change History (20)

comment:1 by umccullough, 12 years ago

Tickets potentially affected since 2012-10-08 (according to my haiku-bugs emails):

#8007 #8900 #9043

edit: removed the already-closed tickets since those patches have been applied anyhow.

Last edited 12 years ago by umccullough (previous) (diff)

comment:2 by bonefish, 12 years ago

Owner: changed from haiku-web to nielx
Status: new → assigned

by nielx, 12 years ago

Attachment: configure-preview-limit-by-mimetype.diff​ added

Test

comment:3 by nielx, 12 years ago

patch: 0 → 1

comment:4 by nielx, 12 years ago

patch: 1 → 0

This is a comment after setting a patch

by nielx, 12 years ago

Attachment: hgshelve.py​ added

Another test

comment:5 by nielx, 12 years ago

patch: 0 → 1

comment:6 by nielx, 12 years ago

Test removal

comment:7 by nielx, 12 years ago

This is fixed in ​attachment flags 0.1.3 and deployed here.

comment:8 by nielx, 12 years ago

Resolution: → fixed
Status: assigned → closed

by umccullough, 12 years ago

Attachment: ticket_9058_snip.PNG​ added

comment:9 by umccullough, 12 years ago

Only one minor nit:

In the "Modify Ticket" interface, it doesn't display properly when there's no patch set yet (after checking and saving, it looks fine).

comment:10 by nielx, 12 years ago

patch: 1 → 0

Ah yes. There was a flaw in the logic of the patch. It should really be fixed now.

in reply to:  10 comment:11 by umccullough, 12 years ago

Resolution: fixed
Status: closed → reopened

Replying to nielx:

Ah yes. There was a flaw in the logic of the patch. It should really be fixed now.

Are you sure?

Now it seems to be back to the original behavior :(

comment:12 by nielx, 12 years ago

patch: 0 → 1

comment:13 by luroh, 12 years ago

patch: 1 → 0

#4494 affected

comment:14 by umccullough, 12 years ago

#9071 affected

comment:15 by umccullough, 12 years ago

#8345 affected

comment:16 by nielx, 12 years ago

patch: 0 → 1

comment:17 by nielx, 12 years ago

Resolution: → fixed
Status: reopened → closed

Updated #9071 #8345

Fixed now. I tested various possibilities on my local machine and I am confident I nailed it now. Let me know if it turns out to still cause issues.

Note: See TracTickets for help on using tickets.